[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/15] Hurd signals: Use POSIX sigcodes
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 15/15] Hurd signals: Use POSIX sigcodes |
Date: |
Thu, 30 Jun 2011 01:23:28 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Jérémie Koenig, le Wed 29 Jun 2011 23:17:49 +0000, a écrit :
> On Wed, Jun 29, 2011 at 10:59 PM, Samuel Thibault
> <samuel.thibault@gnu.org> wrote:
> > Jérémie Koenig, le Wed 29 Jun 2011 22:55:48 +0000, a écrit :
> >> The old !SA_SIGINFO case was a non-standard (BSD-based?) extension. Is
> >> there really anything using it?
> >
> > You can never know. And thus probably have to keep it.
>
> Would mapping the old values to the new ones in the trampoline code be
> an acceptable compromise?
It is probably better than duplicating the mapping everywhere the values
are generated, indeed
> Should I rename the constants so that programs using them would fail
> to compile, and therefore be noticed and, hopefully, updated to the
> more portable SA_SIGINFO interface?
I don't think so. We don't want to unnecessarily break something that
can still work.
> Would it still be ok to introduce POSIX sigcodes where 0 was used before?
I'm not sure about it. I'd say when !SA_SIGINFO, better reset it to 0.
Samuel
- [PATCH 07/15] Hurd signals: fix uninitialized value., (continued)
- [PATCH 07/15] Hurd signals: fix uninitialized value., Jeremie Koenig, 2011/06/29
- [PATCH 04/15] Hurd signals: refactor check_pending_signals, Jeremie Koenig, 2011/06/29
- [PATCH 03/15] _hurd_internal_post_signal: Split out inner functions, Jeremie Koenig, 2011/06/29
- [PATCH 09/15] Hurd signals: implement global signal dispositions, Jeremie Koenig, 2011/06/29
- [PATCH 12/15] Hurd signals: fix global untraced signals., Jeremie Koenig, 2011/06/29
- [PATCH 15/15] Hurd signals: Use POSIX sigcodes, Jeremie Koenig, 2011/06/29
Re: [PATCH 00/15] Hurd signals: please review, Jérémie Koenig, 2011/06/29