Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished

[Richard Braun]

On Wed, Feb 13, 2013 at 06:51:29AM +0100, Svante Signell wrote:
> - the rewritten code is faster than the old one. In the old code no
> delay is needed for the POLL case but is for the rewritten code. i.e.
> it's faster. (irrespective of moving timeouts to the server side or not)

I highly doubt it is, and you've never explained what would make it
faster.

> - you cannot commit this code unless I agree to sign the copyright
> papers for libc (which I of course will when asked for). This is a
> derived work of mine. Otherwise it has to stay as a Debian patch.

Really ? That's what you choose to say here ? Have you at least looked
at the changes he made ? They're really not much like what you've sent
us.

> - in a better world the hurdselect.c code should be split into two
> routines: hurdselect.c and hurdpoll.c with corresponding changes on the
> server side. The code paths are too different to squeeze into one
> function. But nobody dares (or is allowed to) to make major changes
> nowadays. Incremental development is not always the best way to make
> progress.

I've never seen a single system not use common code for poll and select.
There is a good reason for that: at the core it's the same function.

> - regarding programming style: Let's assume you develop a microprocessor
> containing several millions of gates. Which solution is most easily
> developed, maintained, reviewed and bug fixed: A flat netlist design or
> a hierarchical design? Just ask the chip developers, like Intel and AMD.

That's not the question. When you make a change, you make only one
change. Don't mix them into something that just gets unreadable. I
personally wouldn't have cared about the order of the changes (moving
code into helper functions and fixing the poll conformance issue being
the two changes here). But please, one at a time, separately.

Anyway, my feeling about all this is that you're making us waste the
already very sparse amount of time we have to work on this project. You
obviously lack the technical skills to write anything sane in C, but
more importantly the social ones to learn from your mistakes by
correctly communicating with others. The whining about copyright merely
shows how childish you are, and I think you've chosen a project such as
the Hurd just to have your own name printed somewhere. You really don't
seem to care about anything else. Personally, this general and
consistent behaviour made reviewing your work a psychologically painful
task for me. From now on, I won't review _anything_ from you, so that
I won't get silly threats about copyright assignments... Seriously...

And this last act of arrogance about the copyright issue is so rude I
will just say it plainly :

>From now on, I'll completely ignore you. System development is obviously
not for you, go do something else (my early apologies to whoever gets
him in his team). Go away from this project.

-- 
Richard Braun