bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] cleanup of #includes


From: Richard Braun
Subject: Re: [RFC] cleanup of #includes
Date: Thu, 14 Nov 2013 14:14:01 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Nov 14, 2013 at 12:41:30PM +0100, Justus Winter wrote:
> 1. Do you consider the comment describing which symbols are pulled
>    from the header as noise or worthwile information?

Noise.

> 2. Do you consider it too noisy to include mach-shortcuts.h instead of
>    mach.h for stuff like mach_port_allocate?

Yes, but I guess such occurrences are rare.

> 3. libihash/ihash.c includes <hurd/ihash.h>. Shouldn't it include
>    "ihash.h" instead, so that it gets the local version instead of the
>    one in /usr/include?

It probably should, yes.

-- 
Richard Braun



reply via email to

[Prev in Thread] Current Thread [Next in Thread]