[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/19] Fix call of function with qualified void return type
|
From: |
Guillem Jover |
|
Subject: |
Re: [PATCH 03/19] Fix call of function with qualified void return type |
|
Date: |
Wed, 20 Nov 2013 21:18:14 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, 2013-11-20 at 13:53:45 +0100, Marin Ramesa wrote:
> * ddb/db_command.c [DB_MACHINE_COMMANDS]: Add comment after endif.
> * i386/i386/setjmp.h (_longjmp): Comment out __volatile__.
(This patch seems to mix two unrelated changes, at least from the
patch description PoV.)
> diff --git a/i386/i386/setjmp.h b/i386/i386/setjmp.h
> index 667eecf..08626e3 100644
> --- a/i386/i386/setjmp.h
> +++ b/i386/i386/setjmp.h
> @@ -36,7 +36,7 @@ typedef struct jmp_buf {
> extern int _setjmp(jmp_buf_t*);
>
> #ifdef __GNUC__
> -extern __volatile__ void _longjmp(jmp_buf_t*, int);
> +extern /*__volatile__*/ void _longjmp(jmp_buf_t*, int);
> #endif
>
> #endif /* _I386_SETJMP_H_ */
Why not just remove it?
Thanks,
Guillem
[PATCH 04/19] ddb/db_examine.c: fix signedness, Marin Ramesa, 2013/11/20
[PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, Marin Ramesa, 2013/11/20