Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP

[Guillem Jover]

On Wed, 2013-11-20 at 21:48:14 +0100, Samuel Thibault wrote:
> Guillem Jover, le Wed 20 Nov 2013 21:09:08 +0100, a écrit :
> > >  #ifdef   SOFTWARE_SSTEP
> > > +     db_addr_t brpc;
> > >       /* Account for instructions in delay slots */
> > >       brpc = next_instr_address(pc, 1, task);
> > >       if ((brpc != pc) && (inst_branch(ins) || inst_call(ins))) {
> > 
> > This adds intermixing of statements and declarations.
> 
> What kind of problem do you expect?  C99 is almost 15 years old now.

Oh, no compiler problem; sorry, I should have been explicit, I was
thinking about this possibly not being in line with the current
coding style. If it is, then maybe it would be a nice idea to add
something like a coding-style.txt under doc/ perhaps?

Otherwise -Wdeclaration-after-statement is generally useful, even if
the build system requests -std=gnu99 or -std=c99 compilation.

Thanks,
Guillem