[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name
From: |
Marin Ramesa |
Subject: |
Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name |
Date: |
Wed, 20 Nov 2013 22:28:07 +0100 |
On 20.11.2013 22:13:34, Samuel Thibault wrote:
> Marin Ramesa, le Wed 20 Nov 2013 21:59:26 +0100, a écrit :
> > On 20.11.2013 21:44:22, Samuel Thibault wrote:
> > > Marin Ramesa, le Wed 20 Nov 2013 21:31:33 +0100, a écrit :
> > > > On 20.11.2013 21:19:24, Guillem Jover wrote:
> > > > > On Wed, 2013-11-20 at 13:53:47 +0100, Marin Ramesa wrote:
> > > > > > -int db_expression(db_expr_t *valuep);
> > > > > > +int db_expression(db_expr_t *);
> > > > >
> > > > > Why?
> > > >
> > > > It seems there is a collision in names somewhere where
> > > > db_expr.h is included. valuep is a pointer to db_addr_t.
> > >
> > > I don't understand either. Could you quote what is happening?
> >
> > This is GCC output:
> >
> > expected „db_expr_t *” but argument is of type „db_addr_t *”
> >
> > I concluded there is a collision in namespace.
>
> Err, no, it's rather the caller which doesn't use the proper type.
Ah, I see. I fixed that warning and it went away, but I concluded this
patch fixed it.
- Re: [PATCH 03/19] Fix call of function with qualified void return type, (continued)
[PATCH 04/19] ddb/db_examine.c: fix signedness, Marin Ramesa, 2013/11/20
[PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, Marin Ramesa, 2013/11/20
[PATCH 06/19] ddb: fix implicit declaration of function, Marin Ramesa, 2013/11/20
[PATCH 07/19] ddb/db_run.c: remove set but unused variable, Marin Ramesa, 2013/11/20
[PATCH 08/19] ddb/db_run.c: trivial stylistic fix for consistency, Marin Ramesa, 2013/11/20
[PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP, Marin Ramesa, 2013/11/20
[PATCH 10/19] ddb/db_sym.c: add parentheses around assignment used as truth value, Marin Ramesa, 2013/11/20