Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from

bug-hurd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from

From:	Samuel Thibault
Subject:	Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC)
Date:	Sun, 8 Dec 2013 23:25:42 +0900
User-agent:	Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Mon 02 Dec 2013 22:54:39 +0100, a écrit :
> -                     for ( ; (c != K_DONE) && (char_idx <= max);
> +                     for ( ; ((char)c != K_DONE) && (char_idx <= max);

I have rather made K_DONE an unsigned, simply.  It definitely has to be
an unsigned anyway, since it's 0xff...

Samuel

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 10/14] kern/act.c: move struct definition to a header file, (continued)
- [PATCH 10/14] kern/act.c: move struct definition to a header file, Marin Ramesa, 2013/12/02
  - Re: [PATCH 10/14] kern/act.c: move struct definition to a header file, Samuel Thibault, 2013/12/08
- [PATCH 12/14] vm/memory_object_proxy.c: move struct definition to a header file, Marin Ramesa, 2013/12/02
  - Re: [PATCH 12/14] vm/memory_object_proxy.c: move struct definition to a header file, Samuel Thibault, 2013/12/08
- [PATCH 11/14] kern/lock.c: move struct definition to a header file, Marin Ramesa, 2013/12/02
  - Re: [PATCH 11/14] kern/lock.c: move struct definition to a header file, Samuel Thibault, 2013/12/08
- [PATCH 13/14] vm/vm_fault.c: move struct definition to a header file, Marin Ramesa, 2013/12/02
  - Re: [PATCH 13/14] vm/vm_fault.c: move struct definition to a header file, Samuel Thibault, 2013/12/08
- [PATCH 14/14] vm/vm_resident.c: move struct definition to a header file, Marin Ramesa, 2013/12/02
  - Re: [PATCH 14/14] vm/vm_resident.c: move struct definition to a header file, Samuel Thibault, 2013/12/08
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Samuel Thibault <=
  - Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Marin Ramesa, 2013/12/09
    - Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Richard Braun, 2013/12/09
    - Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Marin Ramesa, 2013/12/09
    - Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Richard Braun, 2013/12/09
    - Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Samuel Thibault, 2013/12/09
    - Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Richard Braun, 2013/12/09
    - Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Samuel Thibault, 2013/12/09
    - Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Marin Ramesa, 2013/12/09
    - Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Samuel Thibault, 2013/12/15

Prev by Date: [PATCH 28/28] ddb/db_trap.c (db_task_trap): remove forward declarations
Next by Date: Re: [PATCH 02/14] i386/i386at/kd.c: remove useless old code
Previous by thread: Re: [PATCH 14/14] vm/vm_resident.c: move struct definition to a header file
Next by thread: Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC)
Index(es):
- Date
- Thread