[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/9] libdiskfs: set the default sync interval to 30 seconds
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 1/9] libdiskfs: set the default sync interval to 30 seconds |
Date: |
Mon, 28 Apr 2014 12:29:46 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Mon 28 Apr 2014 12:19:56 +0200, a écrit :
> The default sync interval has been changed in 9e55fdd7 from 30 to 5
> seconds. This change was not reflected in the documentation.
>
> At least for current hardware, using 30 seconds instead of just 5
> alleviates the thread-storm problem. Make 30 seconds the default
> again.
Ack.
> * libdiskfs/priv.h (DEFAULT_SYNC_INTERVAL): Set to 30 seconds.
> ---
> libdiskfs/priv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libdiskfs/priv.h b/libdiskfs/priv.h
> index 4363a00..2ac3c9e 100644
> --- a/libdiskfs/priv.h
> +++ b/libdiskfs/priv.h
> @@ -63,7 +63,7 @@ extern const struct argp_option diskfs_common_options[];
> #define OPT_INHERIT_DIR_GROUP 604 /* --inherit-dir-group
> */
>
> /* Common value for diskfs_common_options and diskfs_default_sync_interval.
> */
> -#define DEFAULT_SYNC_INTERVAL 5
> +#define DEFAULT_SYNC_INTERVAL 30
> #define DEFAULT_SYNC_INTERVAL_STRING STRINGIFY(DEFAULT_SYNC_INTERVAL)
> #define STRINGIFY(x) STRINGIFY_1(x)
> #define STRINGIFY_1(x) #x
> --
> 1.9.2
>
--
Samuel
RK > Some "PC speakers" are actually buzzers in some cases rather than
RK > real loudspeakers which give a squark rather than a beep.
DW They're not _that_ bad. Even on most recent hardware, mp3s played
DW through the PC speaker are relatively recognisable :)
-+- lkml -+-