[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] utils/mount: canonicalize mountpoints

From: Gabriele Giacone
Subject: Re: [PATCH] utils/mount: canonicalize mountpoints
Date: Sun, 15 Jun 2014 01:28:06 +0200

On Sat, Jun 14, 2014 at 10:44 PM, Samuel Thibault
<samuel.thibault@gnu.org> wrote:
> Gabriele Giacone, le Thu 05 Jun 2014 00:34:45 +0200, a écrit :
>> * utils/mount.c (main): realpath mountpoint.
>> * utils/umount.c (do_umount): Likewise.
> Mmm, but sutils/fstab.c already does apply realpath, doesn't it?  I see
> it doing it in fstab_find.

In fstab_find, it just helps finding paths in fstab so that it looks
for both input one as-is and input one realpath'ed. It would probably
be better realpath'ing while reading fstab to fix possible malformed
(extra '/' and '.') paths in fstab (one source) and ...

> What would this be needed for?

... this one would fix malformed mount/umount input paths (another
source. Any else? raw settrans). It would make first and last hunks in
pbuilder.diff [0] useless.

[0] https://lists.debian.org/debian-hurd/2014/06/msg00032.html


reply via email to

[Prev in Thread] Current Thread [Next in Thread]