Re: [PATCH 1/2] pci-arbiter: Rename command line options

[Joan Lledó]

Hi,

El 15/2/20 a les 15:02, Samuel Thibault ha escrit:
> Why a capital b? It's be more coherent to have -d -b -s -f all
> small-caps.
> 

Because of this notice in --help:

"More than one permission scope may be specified. Uppercase options
create a new permission scope if the current one already has a value for
that option. If one node is covered by more than one permission scope,
only the first permission is applied to that node."


The capital options create a new permission scope, for instance:

-B 0 -s 5 -f 0 -B 0 -U 1000

This will create two permission scopes:
1.- 00:05.0 belongs to nobody (Error)
2.- 00:*.* belongs to 1000 (OK)

The second -B has created a new scope, which leaves the previous one
incomplete.


-B 0 -s 5 -f 0 -s 4 -U 1000

This creates only one permission scope: 00:04.0 belongs to 1000. The
second -s overrides the first one.

Until now, the capital option was -D for domain, but this commit makes
the domain optional and sets it to 0000 if not given. That's for
compatibility with Conventional PCI. So I moved the capital option one
level down, to the bus.