[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] rumpkernel dependencies

From: Damien Zammit
Subject: Re: [PATCH] rumpkernel dependencies
Date: Sun, 29 Mar 2020 16:16:50 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

Hurd TODO for Damien:

- Fix libstore patch

- Remove useless debugging eg:

>> +  mach_print("device open\n");

- Remove most of this header:

>> +++ b/libmachdevrump/dev_hdr.h
- Complete the following:

> I see that most of the patch is actually coming from the incubator's
> dde-based libmachdev. I'd rather avoid having two copies of that code in
> different Hurd repos :)
> I'd say what we want to do is:
> - put the files common to dde-based and rump-based libmachdev to
>   libmachdev/.  That includes basically all your files except disk.c,
>   machdevrump.c and Makefile. The only real discrepancy I see is in
>   ds_routines.c' call to l4dde26_process_from_ddekit, but we can make
>   libmachdevdde provide a function that does that call then call
>   ds_server(). AIUI the call to is_master_device() should indeed be made
>   like in the incubator?  I don't think we should deallocate it at the
>   very least, was it really needed in your tests?
> - move the dde-based files (for network) to a libmachdevdde/
> - put your rump-based disk.c to a libmachdevrump/
> and the rumpdisk daemon will just need to link in both libmachdev and
> libmachdevrump.

Thanks Samuel for guidance.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]