Re: [PATCHv2 2/7] hurd: add missing awk script dependency

[Simon Marchi]

On 2020-05-29 6:01 p.m., Samuel Thibault wrote:
> gdb/ChangeLog:
> 
> 2020-05-29  Samuel Thibault  <samuel.thibault@ens-lyon.org>
> 
>       * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
>       $(srcdir)/reply_mig_hack.awk.
> 
> diff --git a/gdb/config/i386/i386gnu.mn b/gdb/config/i386/i386gnu.mn
> index 1c3453823d..5c81efd007 100644
> --- a/gdb/config/i386/i386gnu.mn
> +++ b/gdb/config/i386/i386gnu.mn
> @@ -7,7 +7,7 @@ MIGCOM = $(MIG) -cc cat - /dev/null
>  
>  # Reply servers need special massaging of the code mig generates, to make
>  # them work correctly for error returns in some cases.
> -%_reply_S.h %_reply_S.c: %_reply.defs
> +%_reply_S.h %_reply_S.c: %_reply.defs $(srcdir)/reply_mig_hack.awk
>       $(CPP) $(CPPFLAGS) -DSERVERPREFIX=S_ -x c $< \
>       | $(MIGCOM) -sheader $*_reply_S.h -server $*_reply_S.raw -user 
> /dev/null -header /dev/null \
>       && $(AWK) -f $(srcdir)/reply_mig_hack.awk < $*_reply_S.raw > 
> $*_reply_S.c
> 

Thanks, this is OK, although even if it's obvious to you, I'd appreciate at 
least
a small commit message that explains why this is needed (i.e. make sure those 
out
files are re-generated whenever the script that generates them changes).

Simon