Re: [PATCHv2 1/7] hurd: fix gnu_debug_flag type

[Samuel Thibault]

Simon Marchi, le sam. 30 mai 2020 10:39:19 -0400, a ecrit:
> On 2020-05-29 6:00 p.m., Samuel Thibault wrote:
> > Fixes
> > 
> > ../../gdb/gnu-nat.c:96:6: error: conflicting declaration ‘bool 
> > gnu_debug_flag’
> >    96 | bool gnu_debug_flag = false;
> > ../../gdb/gnu-nat.c: In function ‘void _initialize_gnu_nat()’:
> > ../../gdb/gnu-nat.c:3511:7: error: cannot
> > 
> > gdb/ChangeLog:
> > 
> > 2020-05-29  Samuel Thibault  <samuel.thibault@ens-lyon.org>
> > 
> >     * gnu-nat.h (gnu_debug_flag): Set type to bool.
> > 
> > diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h
> > index 77c57817b2..7c36778394 100644
> > --- a/gdb/gnu-nat.h
> > +++ b/gdb/gnu-nat.h
> > @@ -111,7 +111,7 @@ extern char *proc_string (struct proc *proc);
> >           __proc_pid (__proc), __proc->tid, \
> >           host_address_to_string (__proc) , ##args); } while (0)
> >  
> > -extern int gnu_debug_flag;
> > +extern bool gnu_debug_flag;
> >  
> >  #define debug(msg, args...) \
> >   do { if (gnu_debug_flag) \
> > 
> 
> Thanks, this is OK.

Just to be sure, I don't have commit access so can't commit myself.
I didn't see that case documented on
https://sourceware.org/gdb/wiki/ContributionChecklist
linked from
https://www.gnu.org/software/gdb/contribute/

Samuel