bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix


From: Samuel Thibault
Subject: Re: [PATCH] libmachdev: Install as translator when bootstrapping && fix rumpdisk injection
Date: Sat, 14 Nov 2020 11:09:48 +0100
User-agent: NeoMutt/20170609 (1.8.3)

Damien Zammit, le sam. 14 nov. 2020 14:37:37 +1100, a ecrit:
>  /* BSD name of whole disk device is /dev/wdXd
> - * but we will receive /dev/wdX as the name */
> + * but we will receive /dev/wdX as the name 
> + * or @/dev/master:/dev/wdX */

This looks odd to me. The "@/dev/master:" part should rather be
dropped way before, by the code that opens /dev/master to access the
master device port before calling device_open() on it: the translators
shouldn't have to grok which way they were accessed.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]