[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pci-arbiter: Stop using deprecated region memory pointer
From: |
Samuel Thibault |
Subject: |
Re: [PATCH] pci-arbiter: Stop using deprecated region memory pointer |
Date: |
Fri, 7 Jan 2022 15:03:25 +0100 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Hello,
Joan Lledó, le ven. 07 janv. 2022 12:09:56 +0100, a ecrit:
> - err = pci_device_map_range (device, region->base_addr, region->size,
> - PCI_DEV_MAP_FLAG_WRITABLE, ®ion->memory);
> + /* Use the legacy call for regions under 1MB */
> + if (region->base_addr > 0x100000
> + || region->base_addr + region->size > 0x100000)
> + err = pci_device_map_range (device, region->base_addr, region->size,
> + PCI_DEV_MAP_FLAG_WRITABLE, addr);
> + else
> + err = pci_device_map_legacy (device, region->base_addr, region->size,
> + PCI_DEV_MAP_FLAG_WRITABLE, addr);
Comments are not meant to document the "what" (1MB is already written
in the code), but the "why": why is it that we can't just call
pci_device_map_range for all ranges, whatever the address?
Samuel
[PATCH] pci-arbiter: Stop using deprecated region memory pointer, Joan Lledó, 2022/01/05
Re: [PATCH] pci-arbiter: Stop using deprecated region memory pointer, Samuel Thibault, 2022/01/07