[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-inetutils] Re: ftp: command processing
From: |
Alfred M. Szmidt |
Subject: |
Re: [bug-inetutils] Re: ftp: command processing |
Date: |
Wed, 29 Aug 2007 21:19:23 +0200 (CEST) |
> Even if we use the readline module from gnulib, we have to
> envelop the add_history calls with #if HAVE_LIBREADLINE...#endif
> pairs.
Yes, or perhaps cleaner: add a AC_CHECK_FUNC(add_history) to
configure.ac, and make sure the test code links to any libreadline
found by gnulib. Then wrap the calls to add_history around #if
HAVE_ADD_HISTORY.
Nitpick, that should be HAVE_LIBHISTORY, there is no guarantee that
add_history is part of libreadline. And the check should check for
add_history in libreadline _and_ libhistory.
Another option would be to add the entire libreadline to the gnulib
module, so that it really does provide a add_history replacement as
well. But the libreadline code was rather ugly last time I
checked, so it may be difficult.
Sounds like a terrible idea to put non-trivial code into gnulib, it
isn't supposed to be a dumping group for everything in the GNU
project...
- [bug-inetutils] Re: ftp: command processing, (continued)
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/28
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/28
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/28
- Re: [bug-inetutils] Re: ftp: command processing,
Alfred M. Szmidt <=
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/29
- [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/30
- Re: [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/30
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/31
- Re: [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/31
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/31
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/31
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/15
- Re: [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/23