[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-inetutils] Re: ftp: command processing
From: |
Simon Josefsson |
Subject: |
[bug-inetutils] Re: ftp: command processing |
Date: |
Thu, 30 Aug 2007 05:50:09 +0200 |
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) |
"Alfred M. Szmidt" <address@hidden> writes:
> > Even if we use the readline module from gnulib, we have to
> > envelop the add_history calls with #if HAVE_LIBREADLINE...#endif
> > pairs.
>
> Yes, or perhaps cleaner: add a AC_CHECK_FUNC(add_history) to
> configure.ac, and make sure the test code links to any libreadline
> found by gnulib. Then wrap the calls to add_history around #if
> HAVE_ADD_HISTORY.
>
> Nitpick, that should be HAVE_LIBHISTORY, there is no guarantee that
> add_history is part of libreadline. And the check should check for
> add_history in libreadline _and_ libhistory.
Ah, right. I forgot that add_history is in libhistory.
> Another option would be to add the entire libreadline to the gnulib
> module, so that it really does provide a add_history replacement as
> well. But the libreadline code was rather ugly last time I
> checked, so it may be difficult.
>
> Sounds like a terrible idea to put non-trivial code into gnulib, it
> isn't supposed to be a dumping group for everything in the GNU
> project...
gnulib already contains some non-trivial code like argp, *printf, regex.
Anyway, I guess it is up to the gnulib maintainers to decide. A
question for InetUtils would be whether libreadline should be a hard or
soft dependency.
/Simon
- [bug-inetutils] Re: ftp: command processing, (continued)
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/28
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/28
- [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/28
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/29
- [bug-inetutils] Re: ftp: command processing,
Simon Josefsson <=
- [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/30
- Re: [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/30
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/31
- Re: [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/31
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/31
- [bug-inetutils] Re: ftp: command processing, Simon Josefsson, 2007/08/31
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/15
- Re: [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/15
- Re: [bug-inetutils] Re: ftp: command processing, Alfred M. Szmidt, 2007/08/23
- Re: [bug-inetutils] Re: ftp: command processing, Debarshi 'Rishi' Ray, 2007/08/23