[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-inetutils] Re: [PATCH 1/4] ftp: rename ruserpass to avoid C library
From: |
Mike Frysinger |
Subject: |
[bug-inetutils] Re: [PATCH 1/4] ftp: rename ruserpass to avoid C library collision |
Date: |
Fri, 19 Nov 2010 17:14:47 -0500 |
User-agent: |
KMail/1.13.5 (Linux/2.6.36; KDE/4.5.2; x86_64; ; ) |
On Friday, November 19, 2010 10:12:44 Simon Josefsson wrote:
> Simon Josefsson <address@hidden> writes:
> > Mike Frysinger <address@hidden> writes:
> >> The C library itself defines a "ruserpass" function. When linking
> >> statically, it is possible to hit a symbol collision linker error.
> >> So rename the local ftp version to "remote_userpass".
> >
> > Applied and pushed. Next time, please include a patch for ChangeLog as
> > well.
>
> Btw, would it make sense to _use_ the glibc ruserpass symbol instead of
> providing our own implementation? The glibc implementation looks
> similar to the one we have. On the other hand -- the function is not
> documented in the glibc manual nor is it a POSIX function, so I'm not
> sure how stable the glibc implementation should be considered to be.
i'm not actually using glibc, so i'd prefer we stick to standards rather than
use even more undocumented features.
-mike
signature.asc
Description: This is a digitally signed message part.
[bug-inetutils] [PATCH 4/4] detect fork() support, Mike Frysinger, 2010/11/19
[bug-inetutils] Re: [PATCH 1/4] ftp: rename ruserpass to avoid C library collision, Simon Josefsson, 2010/11/19
[bug-inetutils] K&R prototypes in ftp/extern.h, Simon Josefsson, 2010/11/19