[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-inetutils] Re: K&R prototypes in ftp/extern.h
From: |
Simon Josefsson |
Subject: |
[bug-inetutils] Re: K&R prototypes in ftp/extern.h |
Date: |
Tue, 23 Nov 2010 14:07:18 +0100 |
User-agent: |
Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux) |
address@hidden (Alfred M. Szmidt) writes:
> > --- a/ftp/extern.h
> > +++ b/ftp/extern.h
> > @@ -119,7 +119,7 @@ void reset (int, char **);
> > void restart (int, char **);
> > void rmthelp (int, char **);
> > void rmtstatus (int, char **);
>
> Any reason K&R prototypes are used here? Should we change this?
>
> Just historic reasons, drop them if you want.
I couldn't easily make gcc warn about this, so until we can find a
warning parameter (and enable it, at least for developers) we might as
well postpone this. I'm not sure if changing this makes for any
significant change, I suspect there are many other places we use K&R
prototypes too.
Still, it would be nice to fix this eventually, so the code is a bit
more modern.
/Simon
[bug-inetutils] [PATCH 4/4] detect fork() support, Mike Frysinger, 2010/11/19
[bug-inetutils] Re: [PATCH 1/4] ftp: rename ruserpass to avoid C library collision, Simon Josefsson, 2010/11/19
[bug-inetutils] K&R prototypes in ftp/extern.h, Simon Josefsson, 2010/11/19