[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Do not call toplevel configure in non-VPATH build. (was: libtool-2.2.11a
From: |
Ralf Wildenhues |
Subject: |
Do not call toplevel configure in non-VPATH build. (was: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit) |
Date: |
Sat, 7 Aug 2010 13:08:37 +0200 |
User-agent: |
Mutt/1.5.20 (2010-04-22) |
* Rainer Tammer wrote on Thu, Aug 05, 2010 at 09:25:14AM CEST:
> 112. pic_flag.at:24: testing override pic_flag at configure time ...
> ./pic_flag.at:36: $CC $CPPFLAGS $CFLAGS $C_pic_flag -c foo.c || exit 77
> stderr:
> stdout:
> ./pic_flag.at:39: grep fpic stdout stderr && exit 77
> ./pic_flag.at:46: "$abs_top_srcdir"/configure
> lt_cv_prog_compiler_pic="$C_pic_flag"
> lt_cv_prog_compiler_pic_CXX="$CXX_pic_flag"
> stderr:
> configure: error: source directory already configured; run "make distclean"
> there first
> stdout:
> ## ------------------------------------------------------- ##
> ## Configuring libtool" (Build:1.3224 2010-08-04)" 2.2.11a ##
> ## ------------------------------------------------------- ##
>
> checking for a BSD-compatible install... /opt/freeware/bin/install -c
> checking whether build environment is sane... yes
> checking for a thread-safe mkdir -p... /opt/freeware/bin/mkdir -p
> checking for gawk... no
> checking for mawk... no
> checking for nawk... nawk
> checking whether gmake sets $(MAKE)... yes
> ./pic_flag.at:46: exit code was 1, expected 0
> 112. pic_flag.at:24: 112. override pic_flag at configure time
> (pic_flag.at:24): FAILED (pic_flag.at:46)
Ouch. My bad.
I'm pushing the patch below to avoid the test in this case, and to make
a note in another test to point to the issue.
Thanks,
Ralf
Do not call toplevel configure in non-VPATH build.
* tests/deplibs-mingw.at (deplibs without file command): Use
LT_AT_CONFIGURE for consistency, update comment about why it
might fail.
* tests/pic_flag.at (override pic_flag at configure time): Skip
test if we are building in-tree.
Report by Rainer Tammer.
diff --git a/tests/deplibs-mingw.at b/tests/deplibs-mingw.at
index 68e8386..45aa032 100644
--- a/tests/deplibs-mingw.at
+++ b/tests/deplibs-mingw.at
@@ -74,8 +74,9 @@ EOF
chmod +x bin/file
PATH=`pwd`/bin${PATH_SEPARATOR-:}$PATH
cd new-libtool
- AT_CHECK(["$abs_top_srcdir"/configure $configure_options || exit 77],
- [], [ignore], [ignore])
+ # configure might fail due to in-tree build of toplevel, or
+ # missing configure flags and other reasons.
+ LT_AT_CONFIGURE([|| exit 77], ["$abs_top_srcdir"/configure])
cd ..
LIBTOOL=new-libtool/libtool
export LIBTOOL
diff --git a/tests/pic_flag.at b/tests/pic_flag.at
index c045ed4..ffad842 100644
--- a/tests/pic_flag.at
+++ b/tests/pic_flag.at
@@ -43,6 +43,7 @@ if $CXX $CPPFLAGS $CXXFLAGS $CXX_pic_flag -c foo.cpp; then :;
else
CXX_pic_flag=
fi
+AT_CHECK([test "$at_srcdir" != . || exit 77])
LT_AT_CONFIGURE([lt_cv_prog_compiler_pic="$C_pic_flag" ]dnl
[lt_cv_prog_compiler_pic_CXX="$CXX_pic_flag"],
["$abs_top_srcdir"/configure])
- Re: libtool-2.2.11a on AIX 5.3 / 5.3 current git master - tests/mdemo-inst.test 2./3. occurrence, (continued)
- Re: libtool-2.2.11a on AIX 5.3 / 5.3 current git master - tests/mdemo-inst.test 2./3. occurrence, Rainer Tammer, 2010/08/04
- Re: libtool-2.2.11a on AIX 5.3 / 5.3 current git master - tests/mdemo-inst.test 2./3. occurrence, Ralf Wildenhues, 2010/08/04
- Re: libtool-2.2.11a on AIX 5.3 / 5.3 current git master - tests/mdemo-inst.test 2./3. occurrence, Rainer Tammer, 2010/08/04
- libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit, Rainer Tammer, 2010/08/05
- revert unwanted enabling of libtool tracing (was: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit), Ralf Wildenhues, 2010/08/07
- Re: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit, Rainer Tammer, 2010/08/08
- Re: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit, Ralf Wildenhues, 2010/08/21
- Re: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit, Rainer Tammer, 2010/08/25
- libtool-2.2.11a on AIX 5.3 current git master 2010-08-25 /status, Rainer Tammer, 2010/08/25
- Re: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit, Ralf Wildenhues, 2010/08/08
- Do not call toplevel configure in non-VPATH build. (was: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit),
Ralf Wildenhues <=
- another func_append inlining regression (was: libtool-2.2.11a on AIX 5.3 current git master / followup on the old test suite and failures in the new testsuit), Ralf Wildenhues, 2010/08/09
libtool-2.2.11a on AIX 5.3 / 6.1 current git master - new test suite failing: 1, 2, 3, ..., Rainer Tammer, 2010/08/04