[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spurious tests are run in the old testsuite.

From: Ralf Wildenhues
Subject: Re: Spurious tests are run in the old testsuite.
Date: Sun, 12 Sep 2010 10:53:17 +0200
User-agent: Mutt/1.5.20 (2010-04-22)

Hi Peter,

* Peter Rosin wrote on Fri, Sep 10, 2010 at 11:04:09AM CEST:
> Den 2010-09-10 10:48 skrev Peter Rosin:
> > Sigh. So, there is no way to run mdemo2-make.test and mdemo2-exec.test
> > on systems where mdemo-dryrun.test fails.
> I managed to run them by removing the offending dependency
> in the generated Makefile. Both of the previously skipped
> mdemo2 tests passed and I could finally check what $NM code
> paths they cover in the libtool script.

Your mails touch on several different but related issues.  Let's address
this one first.  Does the patch below make things work better for you?

The problem with the patch is that it weakens up dependencies a wee bit
too much: mdemo2-make needs tests/mdemo/libmlib.la to exist, and for
that, either mdemo-make or mdemo-dryrun need to have run beforehand.
Portable make unfortunately cannot express OR relationships well.

So the patch may get you in a situation where mdemo2-make will SKIP
because prerequisites are missing.  Oh well.

By the way, in cases where the Makefile is really messed up, you can
still run tests manually from the command line, as in:
  $ cd $top_builddir
  $ ../libtool/tests/mdemo2-make.test


    tests: avoid hard dependency of mdemo2-make on mdemo-dryrun.
    * Makefile.am (tests/mdemo2-make.log): Weaken dependency on
    tests/mdemo-dryrun.log to be order-only.  Add order-only
    dependency on tests/mdemo-make.log.
    Report by Peter Rosin.

diff --git a/Makefile.am b/Makefile.am
index dcd0876..0e722a3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -863,8 +863,9 @@ tests/mdemo-static-exec.log:        
 tests/mdemo-static-make.log:   tests/mdemo-static.log
 tests/mdemo2-exec.log:         tests/mdemo2-make.log
-tests/mdemo2-make.log:         tests/mdemo2-conf.log \
-                               tests/mdemo-dryrun.log
+tests/mdemo2-make.log:         tests/mdemo2-conf.log
+tests/mdemo2-make.log: @ORDER@ tests/mdemo-dryrun.log \
+                               tests/mdemo-make.log
 tests/pdemo-inst.log:          tests/pdemo-exec.log
 tests/pdemo-exec.log:          tests/pdemo-make.log

reply via email to

[Prev in Thread] Current Thread [Next in Thread]