bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 2171 in lilypond: Patch: Implements DOM-id property for grobs.


From: Graham Percival
Subject: Re: Issue 2171 in lilypond: Patch: Implements DOM-id property for grobs.
Date: Fri, 6 Jan 2012 09:44:12 +0000
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Jan 06, 2012 at 09:37:51AM +0000, address@hidden wrote:
> 
> I don't think it's good practice to unilaterally bounce patches from
> staging based on one's personal opinion of the quality of the patch,
> especially when the patch has had a human LGTM from the best SVG
> developer on the team.

+1

I would be delighted to see more questions, comments, or even
arguments, during the countdown phase.  But once it's gone through
the countdown, the only reason patches should be bounced is if
they fail the objective tests in Patchy (i.e. able to complete
make, make test, and make doc).

Cheers,
- Graham



reply via email to

[Prev in Thread] Current Thread [Next in Thread]