RE: Parted 1.5.5-pre4

[Matt_Domsch]

> Ah, good point.  BTW, there's probably no need to clobber the
> ptes, since they have no (possibly) confusing signatures.

OK.
 
> > * references to sectors being 512 bytes should be changed to use
> > dev->sector_size, and test that it's at least 512, maybe in 
> gpt_probe.  The
> > only place 512 need be coded is in defining the reserved 
> space at the end of
> > GuidPartitionTableHeader_t.
> 
> So, what happens when the sector size != 512?

Take for example 1K sectors.  Then the PMBR is 1 sector, the GPT headers are
each 1 sector, and the partition table entries (normally 32 sectors) are
instead 16 sectors (they're defined to be minimum of 16K, where the headers
and pmbr are defined to be 1 sector each).
 
> Must partitions be aligned to the sector size?

Yes.  All partitions are described as start/end pairs on logical blocks (the
device's idea of a sector).  So far we've only used disks with 512-byte
sectors, but that isn't strictly required.  One *could* use 2048 byte
sectors.  I thought that dev->sector_size wasn't hard-coded to 512, but
asked the device what its sector size is and uses that?  I tried to replace
all references to 512 (except in the header struct definition) to be
dev->sector_size for this reason.

Thanks,
Matt

-- 
Matt Domsch
Sr. Software Engineer
Dell Linux Solutions
www.dell.com/linux
#1 US Linux Server provider with 24% (IDC Sept 2001)
#2 Worldwide Linux Server provider with 17% (IDC Sept 2001)
#3 Unix provider with 18% in the US (Dataquest)!