[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: confusing message patch
From: |
K.G. |
Subject: |
Re: confusing message patch |
Date: |
Sat, 16 Jul 2005 14:19:45 +0200 |
On Thu, 14 Jul 2005 14:01:31 -0400 (EDT)
Chris Lumens <address@hidden> wrote:
> Unfortunately, I can't test this since I have no disks with weird sector
> sizes. It compiles, though. If this looks like a good fix to everyone
> on this list, I can talk to the bug reporter to see about him testing
> it.
Your patch make sens to me. I don't think it can break anything, and it's
clearer than the previous error message. I don't know if a single message
with three options could be better, because the available options won't
easily map to the needed { abort, continue with driver sector size,
continue with Parted sector size }
But anyway in the current code state, i'm afraid that non 512 bytes by
sector HD just won't work with parted in most cases.
Cheers,
Guillaume Knispel