[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: memory leak in gpt.c (Fixed the correct way)
From: |
Patrick Leslie Polzer |
Subject: |
Re: memory leak in gpt.c (Fixed the correct way) |
Date: |
Mon, 26 Dec 2005 10:48:03 +0100 |
On Sun, 25 Dec 2005 23:41:48 -0600
Harley D. Eades III <"Harley D. Eades III" <address@hidden>> wrote:
| On Fri, 2005-12-23 at 16:40 -0600, Harley D. Eades III wrote:
| > On Fri, 2005-12-23 at 23:19 +0100, Patrick Leslie Polzer wrote:
| > > On Fri, 23 Dec 2005 00:21:08 -0600
| > > Harley D. Eades III <"Harley D. Eades III" <address@hidden>> wrote:
| > >
| > > | +
| > > | + ped_free (gpt->Reserved2);
| > > | + ped_free (gpt);
| > > | ped_free (pth_raw);
| > > I think this justifies a pth_free() function.
| Done, here she is. :) These are the only places I could see right off
| that needed to use pth_free(), if anyone knows any other spots please
| add them, we need to make sure we don't have memory leaks in libparted.
Speaking of automated error detection, there is a C compiler by Fabrice
Ballard that does bounds checking (and claims to be very fast because of its
monolithic architecture). It is called tcc (Tiny C Compiler).
I haven't checked yet whether Parted-current compiles with it, however.
| Ok to commit?
Looks fine, go ahead.
Thanks :)
~ Leslie
--
PGP-KID: 0x52D70289
pgpTOzGHIUEmb.pgp
Description: PGP signature
- memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/23
- Re: memory leak in gpt.c (Fixed the correct way), Patrick Leslie Polzer, 2005/12/23
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/23
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way),
Patrick Leslie Polzer <=
- Re: memory leak in gpt.c (Fixed the correct way), Håkon Løvdal, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Patrick Leslie Polzer, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Patrick Leslie Polzer, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Otavio Salvador, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/26