Re: parted-1.9.0 -- comments and patches

[Joel Granados]

On Thu, Jul 30, 2009 at 02:15:24PM +0200, Peter Breitenlohner wrote:
> Hi,
>
> I'd like to suggest the attached two patches:
>
> (1) patch-01-test-scripting:

So does t7000 fail for you always?  How are you executing the tests?

>
> without this the test failed.
>
> (2) patch-02-check-programs:
>
> I am fairly sure you don't want to install the two test programs 'disk' and
> 'label' (they are not mentioned under %files in parted.spec). Thus they
> ought to be declared as check_PROGRAMS instead of bin_PROGRAMS.

I would not trust the spec.in file in parted.  We are "maintaining" it
but it usualy is the last thing that gets changed.

>
> Regards
> Peter Breitenlohner <address@hidden>

> diff -ur parted-1.9.0.orig/tests/t7000-scripting.sh 
> parted-1.9.0/tests/t7000-scripting.sh
> --- parted-1.9.0.orig/tests/t7000-scripting.sh        2009-07-23 
> 19:52:08.000000000 +0200
> +++ parted-1.9.0/tests/t7000-scripting.sh     2009-07-30 12:03:17.000000000 
> +0200
> @@ -28,7 +28,7 @@
>  
>  { emit_superuser_warning
>    sed s/Error/Warning/ errS
> -  printf 'Is this still acceptable to you?\nYes/No?'; } >> errI || fail=1
> +  printf 'Is this still acceptable to you?\nYes/No? n\n'; } >> errI || fail=1
>  
>  for mkpart in mkpart mkpartfs; do
>  

> Only in parted-1.9.0: autom4te.cache
> diff -ur parted-1.9.0.orig/libparted/tests/Makefile.am 
> parted-1.9.0/libparted/tests/Makefile.am
> --- parted-1.9.0.orig/libparted/tests/Makefile.am     2009-07-23 
> 19:52:08.000000000 +0200
> +++ parted-1.9.0/libparted/tests/Makefile.am  2009-07-30 13:34:24.000000000 
> +0200
> @@ -5,7 +5,7 @@
>  
>  TESTS = t1000-label.sh t2000-disk.sh
>  EXTRA_DIST = $(TESTS)
> -bin_PROGRAMS = label disk
> +check_PROGRAMS = label disk
>  
>  LDADD = \
>    $(top_builddir)/libparted/libparted.la \

> _______________________________________________
> bug-parted mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/bug-parted


-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

pgpgH0oWURQ2X.pgp
Description: PGP signature