[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: parted-1.9.0 -- comments and patches

From: Curtis Gedak
Subject: Re: parted-1.9.0 -- comments and patches
Date: Fri, 31 Jul 2009 14:20:44 -0600
User-agent: Thunderbird (X11/20090608)

Peter Breitenlohner wrote:
....  Did you test
your patch.  Does it really fix the fact that that the test does not
PASS. ...

Yes, of course.  The result was the same when running the test via my
build+check+install script or when running 'make check' interactively in the tests/ directory (of the build tree): FAIL without the patch, PASS with it.

...  judging by your output, adding a "n" to the end of the string
will not make it succeed.

The difference is that the test (t7000-scripting) asks a question ansered by
'n', whereas the example doesn't ask.  Thus the "echo n |" is ignored and
has no effect.

I too am experiencing a similar problem with failed tests when I run "make check" on parted-1.9.0.

I do not have the readline package installed and hence configure the code with:

    ./configure --without-readline

Perhaps the failure of the two tests is related to whether readline is installed or not?

Curtis Gedak

reply via email to

[Prev in Thread] Current Thread [Next in Thread]