CVS Texinfo: makeinfo crashes with --command-in-node-names

[Akim Demaille]

This bug report is extremely rude, I'm very sorry about that.  I don't
have much time to track down the problem, and especially to make a
small test case: my quick attempts to shrink the following file led to
a different behavior from makeinfo.  So I left it as is (way too big),
and proceeded.

The file attached is broken: it's structure is wrong.  Some sections
(@section T<N> Improvements) ought to be @subsection, and that's what
the @menu announces actually.  So I am not stuck with this bug: I have
fixed my file.  There is no urgency in any way.

Still, it results in a segv you might want to track:

~ % LC_ALL=C src/texinfo/makeinfo/makeinfo --commands-in-node-names  
assignments.texi
zsh: segmentation fault  LC_ALL=C src/texinfo/makeinfo/makeinfo 
--commands-in-node-names 

BTW, Valgrind seems not to like makeinfo too much:

==12653== Memcheck, a.k.a. Valgrind, a memory error detector for x86-linux.
==12653== Copyright (C) 2002-2003, and GNU GPL'd, by Julian Seward.
==12653== Using valgrind-20030725, a program supervision framework for 
x86-linux.
==12653== Copyright (C) 2000-2003, and GNU GPL'd, by Julian Seward.
==12653== Estimated CPU clock rate is 1673 MHz
==12653== For more details, rerun with: -v
==12653== 
==12653== Source and destination overlap in strcpy(0x413a86b0, 0x413a86b1)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055E64: convert_from_loaded_file (makeinfo.c:1518)
==12653==    by 0x8054DF4: main (makeinfo.c:785)
==12653== 
==12653== Conditional jump or move depends on uninitialised value(s)
==12653==    at 0x40008ABA: _dl_relocate_object_internal (in /lib/ld-2.3.2.so)
==12653==    by 0x4035BCF0: (within /lib/libc-2.3.2.so)
==12653==    by 0x4000B115: _dl_catch_error_internal (in /lib/ld-2.3.2.so)
==12653==    by 0x4035BF5B: _dl_open (in /lib/libc-2.3.2.so)
==12653== 
==12653== Conditional jump or move depends on uninitialised value(s)
==12653==    at 0x40008B05: _dl_relocate_object_internal (in /lib/ld-2.3.2.so)
==12653==    by 0x4035BCF0: (within /lib/libc-2.3.2.so)
==12653==    by 0x4000B115: _dl_catch_error_internal (in /lib/ld-2.3.2.so)
==12653==    by 0x4035BF5B: _dl_open (in /lib/libc-2.3.2.so)
==12653== 
==12653== Source and destination overlap in strcpy(0x413d2558, 0x413d2559)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x804A506: cm_settitle (cmds.c:1055)
==12653== 
==12653== Source and destination overlap in strcpy(0x413d2618, 0x413d2619)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x8059BB8: handle_variable (makeinfo.c:3854)
==12653== 
==12653== Source and destination overlap in strcpy(0x413d2623, 0x413d2623)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8059CA9: handle_variable_internal (makeinfo.c:3925)
==12653==    by 0x8059BD7: handle_variable (makeinfo.c:3860)
==12653== 
==12653== Source and destination overlap in strcpy(0x413d6b04, 0x413d6b05)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x8051A04: cm_documentencoding (lang.c:503)
==12653== 
==12653== Source and destination overlap in strcpy(0x413db544, 0x413db545)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x80511DA: cm_end (insertion.c:1472)
==12653== 
==12653== Source and destination overlap in strcpy(0x413db96c, 0x413db96c)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x8053035: define_macro (macro.c:606)
==12653== 
==12653== Source and destination overlap in strcpy(0x413dbfa8, 0x413dbfa8)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8053E42: cm_alias (macro.c:1012)
==12653==    by 0x8056B7D: read_command (makeinfo.c:1962)
==12653== 
==12653== Source and destination overlap in strcpy(0x413dcb04, 0x413dcb05)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x804E69B: gen_defindex (index.c:397)
==12653== 
==12653== Source and destination overlap in strcpy(0x413de69c, 0x413de69d)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x804A852: cm_center (cmds.c:1185)
==12653== 
==12653== Source and destination overlap in strcpy(0x413dea38, 0x413dea39)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x80550FF: fix_whitespace (makeinfo.c:889)
==12653==    by 0x805B3AC: get_node_token (node.c:146)
==12653== 
==12653== Source and destination overlap in strcpy(0x413dee6c, 0x413dee6c)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x80550FF: fix_whitespace (makeinfo.c:889)
==12653==    by 0x805B9D4: glean_node_from_menu (node.c:462)
==12653== 
==12653== Source and destination overlap in strcpy(0x413defb0, 0x413defb0)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x80550FF: fix_whitespace (makeinfo.c:889)
==12653==    by 0x805B403: expand_node_name (node.c:169)
==12653== 
==12653== Source and destination overlap in strcpy(0x413df604, 0x413df605)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x805E9BD: insert_and_underscore (sectioning.c:369)
==12653== 
==12653== Source and destination overlap in strcpy(0x413e82a4, 0x413e82a4)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x80550FF: fix_whitespace (makeinfo.c:889)
==12653==    by 0x8058189: get_xref_token (makeinfo.c:3021)
==12653== 
==12653== Source and destination overlap in strcpy(0x41454a7c, 0x41454a7d)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x804F52B: get_item_function (insertion.c:135)
==12653== 
==12653== Source and destination overlap in strcpy(0x41454b84, 0x41454b84)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x8051384: cm_item (insertion.c:1526)
==12653== 
==12653== Source and destination overlap in strncpy(0x4144e9a9, 0x4144e9aa, 7)
==12653==    at 0x40021FB9: strncpy (mac_replace_strmem.c:95)
==12653==    by 0x8057684: add_char (makeinfo.c:2539)
==12653==    by 0x8056D87: reader_loop (makeinfo.c:2116)
==12653==    by 0x8055F89: convert_from_loaded_file (makeinfo.c:1596)
==12653== 
==12653== Source and destination overlap in strcpy(0x41617544, 0x41617545)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x804A56E: cm_sp (cmds.c:1082)
==12653== 
==12653== Source and destination overlap in strcpy(0x41617578, 0x41617579)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x804E19A: index_add_arg (index.c:200)
==12653== 
==12653== Source and destination overlap in strncpy(0x4144ea24, 0x4144ea29, 67)
==12653==    at 0x40021FB9: strncpy (mac_replace_strmem.c:95)
==12653==    by 0x8057684: add_char (makeinfo.c:2539)
==12653==    by 0x8056D87: reader_loop (makeinfo.c:2116)
==12653==    by 0x805A164: execute_string (makeinfo.c:4154)
==12653== 
==12653== Source and destination overlap in (null)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x804B521: defun_internal (defun.c:361)
==12653== 
==12653== Source and destination overlap in (null)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8050A7F: do_enumeration (insertion.c:1171)
==12653==    by 0x8050B5A: cm_enumerate (insertion.c:1197)
==12653== 
==12653== Source and destination overlap in (null)
==12653==    at 0x40021E99: strcpy (mac_replace_strmem.c:87)
==12653==    by 0x80550CB: canon_white (makeinfo.c:867)
==12653==    by 0x8055638: get_rest_of_line (makeinfo.c:1111)
==12653==    by 0x804EE2B: cm_printindex (index.c:675)
==12653== 
==12653== Invalid read of size 1
==12653==    at 0x4002206B: strcmp (mac_replace_strmem.c:223)
==12653==    by 0x805DC5C: validate_file (node.c:1400)
==12653==    by 0x805616B: convert_from_loaded_file (makeinfo.c:1655)
==12653==    by 0x8054DF4: main (makeinfo.c:785)
==12653==    Address 0x0 is not stack'd, malloc'd or free'd


Thanks!

assignments.texi.bz2
Description: Binary data