Re: PDF destination names for pdfTeX and LuaTeX

[Gavin Smith]

On 4 August 2016 at 17:04, Masamichi Hosoda <address@hidden> wrote:
> I've made the patch that fixes PDF destination names, etc.
> for pdfTeX and LuaTeX.
>
> May I commit it?

Yes, I'm happy for you to commit it. I couldn't find any problems with
the testing I did with pdftex. Specifically, the problems I reported
at http://lists.gnu.org/archive/html/help-texinfo/2016-06/msg00014.html
didn't reappear.

However, I don't understand the change or it's purpose. Can you help
me to understand it by giving an example of the problem this change is
supposed to fix?

If I understand correctly, the destname is just used internally for
cross-references within a PDF file, and it doesn't really matter
what's in it, as long as it is unique.

I wonder if it's possible to put the code for getting the "destination
name" in a macro (a \def) so that it can be used when outputting a
target (e.g. @node) and when referring to a target (e.g. @xref or the
PDF sidebar). That could simplify the code and reduce duplication.

This part of the patch looks confusing:

+     \iftxiuseunicodedestname
+       \ifx \declaredencoding \latone
+         % Pass through Latin-1 characters.
+       \else

If we're using Unicode, then how can we be using Latin-1 at the same time?