Re: [PATCH] Add 'pre-inst-env' wrapper script

[Mathieu Lirzin]

Gavin Smith <address@hidden> writes:

> On Sat, Aug 26, 2017 at 06:41:47PM +0200, Mathieu Lirzin wrote:
>
>> While hacking on 'texi2any' and testing my changes with manuals located
>> in various places in the filesystem, I found it cumbersome to launch the
>> non installed 'makeinfo' like this:
>> 
>>   TEXINFO_DEV_SOURCE=1 top_srcdir=~/src/texinfo/trunk \
>>     ~/src/texinfo/trunk/build/tp/makeinfo --html hello.texi
>> 
>> In Guile projects, which has the same issue of dynamic module loading as
>> Perl, it is a common pratice to add a 'pre-inst-env' wrapper script in
>> the top build directory.  This wrapper augments some environment
>> variables to allows users to easily launch the program from the build
>> environment.  The previous command would be replaced by:
>> 
>>   ~/src/texinfo/trunk/build/pre-inst-env makeinfo --html hello.texi
>> 
>> Beyond the user convenience, it can be used for launching the tests both
>> manually and in the Makefile without having to mess with paths or 'perl
>> -I' in multiple places.
>> 
>> Here is a patch for adding such script:
>
> I've committed the patch as-is, although I haven't tested it yet.

I think you forgot to include build-aux/pre-inst-env.in in revision
r7954.

> I wonder if TEXINFO_UNINSTALLED should be TEXINFO_DEV_SOURCE

Yes, we can either use TEXINFO_DEV_SOURCE or rename it to
TEXINFO_UNINSTALLED.

> and if it should mention build-aux/ in Makefile.am.

My patch was missing this configure.ac change:

--8<---------------cut here---------------start------------->8---
AC_CONFIG_FILES([pre-inst-env:build-aux/pre-inst-env.in],
  [chmod +x pre-inst-env])
--8<---------------cut here---------------end--------------->8---

with that, it should not be necessary to mention build-aux/ in
Makefile.am.  I will commit build-aux/pre-inst-env.in and the missing
configure.ac part later today.

Additionnally some cleanups could be done such as removing the
'top_builddir' and 'top_srcdir' environment variables handling in
'texi2any' and 'Texinfo/ModulePath.pm'.  I can look into that if that's
OK with you.

Thanks.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37