[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add 'pre-inst-env' wrapper script
|
From: |
Hans-Bernhard Bröker |
|
Subject: |
Re: [PATCH] Add 'pre-inst-env' wrapper script |
|
Date: |
Fri, 22 Sep 2017 18:41:16 +0200 |
|
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
Am 22.09.2017 um 12:26 schrieb Mathieu Lirzin:
My patch was missing this configure.ac change:
--8<---------------cut here---------------start------------->8---
AC_CONFIG_FILES([pre-inst-env:build-aux/pre-inst-env.in],
[chmod +x pre-inst-env])
--8<---------------cut here---------------end--------------->8---
with that, it should not be necessary to mention build-aux/ in
Makefile.am.
Doing it that way, combined with the addition of
CLEANFILES= $(noinst_SCRIPTS)
to Makefile.am, would appear to break the usual symmetry rules for the
cleaning targets: "make clean" should only remove stuff that "make"
built. Stuff built by "configure" or "config.status" is supposed to
only be removed by "distclean".
I.e. with the above, a
./configure
make
make clean
make
run would tend to end up with the pre-inst-env file missing.