[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: texinfo-6.8: Test failing

From: Gavin Smith
Subject: Re: texinfo-6.8: Test failing
Date: Tue, 6 Jul 2021 13:10:59 +0100
User-agent: Mutt/1.9.4 (2018-02-28)

On Tue, Jul 06, 2021 at 02:39:09PM +0300, Eli Zaretskii wrote:
> > From: Gavin Smith <gavinsmith0123@gmail.com>
> > Date: Mon, 5 Jul 2021 23:09:10 +0100
> > 
> > In commit 8e53ffed59 I added code to run "locale -a" as a backup; hopefully
> > this will mostly resolve this issue.
> What will happen on platforms that don't have the 'locale' command
> installed (MS-Windows)?  Should the code perhaps refrain from invoking
> the command if it isn't available, or at least shut up any resulting
> error messages?
> Thanks.

The code checks for en_US and en_US.UTF-8 first.  If either of those work,
then 'locale' will not be run.  Have you checked if document translation
works under MS-Windows?  I gave instructions here -
https://lists.gnu.org/archive/html/bug-texinfo/2021-02/msg00157.html - or
you could run the test_scripts/layout_formatting_fr_icons.sh test.

If that is not enough maybe there is something else we could do before
trying to call 'locale' for the benefit of MS-Windows.

If the code does try to run 'locale' but the command doesn't exist, I agree
that we need to stop the error messages.  When I comment out the code to
use en_US etc. and change the command name to "localexx", I get many
warnings printed:

Can't exec "localexx": No such file or directory at ../../tp/Texinfo/Report.pm 
line 264.
Use of uninitialized value in split at ../../tp/Texinfo/Report.pm line 264.

I have made a change (commit 13364f2fa5) to only attempt to run 'locale' once
so that there will not be an error message (and performance hit) every time
a document string is attempted to be translated.

If the translation is not going to happen at all, we should have some
error message printed if the document language is not English.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]