[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] install-info: Fix dir file mode being restricted
|
From: |
Gavin Smith |
|
Subject: |
Re: [PATCH] install-info: Fix dir file mode being restricted |
|
Date: |
Fri, 24 Feb 2023 17:48:45 +0000 |
On Fri, Feb 24, 2023 at 05:16:47PM +0100, Arsen Arsenović wrote:
> The recent switch to mkstemp and atomic updating of the directory
> file unintentionally lead to overly restrictive permissions being
> set on directory file. This error was originally introduced in
> 93162b78d84f731710025b300bc0cd7ca8b14347 (2022-12-03 Gavin Smith
> <gavinsmith0123@gmail.com>).
> * install-info/install-info.c (output_dirfile): Change mode of
> installed dir file back to its usual value, rather than the
> mkstemp default of 0600.
> ---
> Hi,
>
> After updating my system to the latest Texinfo development version, I
> noticed that my dir node became unreadable for regular users. After a
> bit of digging around portage sources, I noticed that this mode was set
> by install-info. This reminded me of the recent change to install-info,
> with making it use mkstemp. mkstemp creates files with a highly
> restricted mode, rather than respecting umask. This patch reverts that
> unintentional effect.
>
> OK for master? Tested on x86_64-pc-linux-gnu.
Yes please. After you commit this I will cherry-pick to the release
branch as this is a severe bug in install-info. I had never tested it
as root, only with a regular user account, so hadn't noticed the
permissions problem.