[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] install-info: Fix dir file mode being restricted
|
From: |
Gavin Smith |
|
Subject: |
Re: [PATCH] install-info: Fix dir file mode being restricted |
|
Date: |
Sun, 26 Feb 2023 13:39:28 +0000 |
On Sun, Feb 26, 2023 at 12:23:46PM +0100, Patrice Dumas wrote:
> I now have failures with the install-info tests checks, I haven't
> investigated, but my feeling is that something needs to be updated after
> this change.
It breaks for me too. The tests have output like
+ ../../install-info/ginstall-info
../../install-info/tests/ii-0001-input-info-file ii01-eiGaE2Zf
chmod: Bad file descriptor
The line in the program
if (fchmod (tempfile, 0666 & um) < 0)
occurs after fclose is called on the FILE opened from the tempfile file
descriptor, which may be part of the problem. The other part of the
code that is incorrect is that if the output is being written via a
pipe (to a compression program), the tempfile fd is also closed early.