Re: [Chicken-hackers] [PATCH] Reschedule when a thread blocked on thread-join! is forcibly resumed

[Jörg F . Wittenberger]

Am 02.06.2016 um 13:28 schrieb Evan Hanson:
> On 2016-06-02 11:32, Jörg F. Wittenberger wrote:
>> No need to actually try.  You patch does exactly what my first
>> workaround was when I discovered the issue.
> 
> Excellent, in that case we can re-hide `##sys#force-primordial` if this
> is applied.

Could we delay that hiding for a while please.

I just started testing a release of our code; eventually no longer
including a custom Chicken.  It would be my nightmares coming true if
I'd fall back into the situation that production code was incompatible
to chicken master.

>> However it looks to me as curing the symptom rather then cause.
>>
>> Convince me otherwise: IMHO forcing the primordial to execute is the
>> actual bug.  Once we don't do this anymore, we can go over all the code
>> and remove the code dealing with the consequences.
> 
> Yes, it fixes a bug without making other changes to the scheduler. The
> current behaviour is obviously incorrect and the patch addresses the
> obvious incorrectness, that's all.
> 
> AFAICT from past discussions, whether forcing is good, bad, or just a
> necessary evil is still unclear, and this needs some agreement before we
> can simply rip out that code. I'm open to removing it in chicken-5, at
> least, which is where something like a dedicated interrupt handling
> thread could go should one materialize. If anyone has any thoughts about
> this, please speak up.

Aside: it makes it easier to experiment with alternative implementations
if the hook is accessible.

Cheery

/Jörg