chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Always quote symbols starting or ending wi


From: felix . winkelmann
Subject: Re: [Chicken-hackers] [PATCH] Always quote symbols starting or ending with a colon to ensure readability
Date: Mon, 03 Jun 2019 12:33:18 +0200

> Hi all,
>
> We've seen quite a bit of breakage with the CR patch.  Most of it has
> been fixed by aeec82d, but it also uncovered another bug that has been
> there since the beginning.  Eggs using srfi-128 fail, see for example:
> https://salmonella-freebsd-x86-64.call-cc.org/master/clang/freebsd/x86-64/2019/05/26/salmonella-report/install/srfi-113.html
>
> This is because srfi-128 contains identifiers like :type-test:.  Now
> that keywords can no longer be assigned to, I had to submit a pull
> request to this egg to add "-keyword-style none" to the compilation
> options, but apparently that causes the types file to be emitted without
> pipe quotes around :type-tests: and other identifiers, so they will be
> read as keywords unless the other egg also happens to use
> "-keyword-style none".
>
> The attached patch ensures we write such identifiers as |:type-tests:|
> regardless of keyword style.  This way, it can also be read by any
> program, even if it uses a different keyword style than the writer.
>

Signed off and pushed.


felix




reply via email to

[Prev in Thread] Current Thread [Next in Thread]