Re: more diffs

[Eric Blake]

Matthias Pfisterer wrote:

> Hi,
>
> another couple of fixes (attached).
>
> Matthias
>
>
> ------------------------------------------------------------------------
>
>  public interface Position
>  {
> -    static class Bias
> +    public static final class Bias

Remove the static modifier, rather than adding public.  Interface member 
classes are implicitly public static.

> +++ java/awt/TextComponent.java 20 Jan 2004 21:53:52 -0000
> @@ -235,10 +235,10 @@
>    * positions are silently fixed.
>    *
>    * @param startSelection The new start position for the selected text.
              ^
If you are going to fix selectionEnd, you should fix selectionStart, too.

> -  * @param endSelection The new end position for the selected text.
> +  * @param selectionEnd The new end position for the selected text.
>    */
>  public synchronized void
> -select(int selectionStart, int endSelection)
> +select(int selectionStart, int selectionEnd)
>  {
>    if (selectionStart < 0)
>      selectionStart = 0;

Was this patch complete? You changed a parameter name, but the body of the 
method does not show any use of this updated name.

> ------------------------------------------------------------------------
>
> Index: vm/reference/java/lang/VMClass.java
> ===================================================================
> RCS file: /cvsroot/classpath/classpath/vm/reference/java/lang/VMClass.java,v
> retrieving revision 1.8
> diff -u -r1.8 VMClass.java
> --- vm/reference/java/lang/VMClass.java 17 Apr 2003 12:32:29 -0000      1.8
> +++ vm/reference/java/lang/VMClass.java 20 Jan 2004 21:57:30 -0000
> @@ -81,7 +81,7 @@
>  
>    private void initialize(int thread) throws InterruptedException
>    {
> -    Error error;
> +    Error error = null;

Is this necessary?  If it was compiling correctly before your patch, then you 
have introduced an inefficiency by redundantly assigning the variable to null.

--
Someday, I might put a cute statement here.

Eric Blake             address@hidden