commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Always send patch/diff to commit-classpath before committing


From: Mark Wielaard
Subject: Always send patch/diff to commit-classpath before committing
Date: Thu, 25 Mar 2004 18:09:00 +0100

Hi,

I didn't see the following changes go through the commit-classpath
mailinglist.

2004-03-22  Ingo Proetel  <address@hidden>

    * java/awt/event/MouseEvent.java (<init>): fixed field assignment

2004-03-22 Ingo Proetel <address@hidden>

    * java/awt/Graphics.java (draw3DRect): fixed lower horizontal line

2004-03-22  Ingo Proetel  <address@hidden>

    * java/awt/FontMetrics.java:
    (charsWidth): fixed accumulation of total_width
    (getWidth): simple default implementation

All these changes do look sane to me (and thanks for catching these
bugs!), but you should always send a diff to the commit-classpath
mailinglist before actually committing so others can easily see what you
wanted to change. Especially important for these classes since most
development is now done in another tree (libgcj branch).

Small nitpick though. ChangeLog entries should be sentences starting
with a capital and ending with a period.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]