Re: [Discuss-gnuradio] Segmentation fault in wav file sink

[Martin Braun]

On Mon, Dec 12, 2011 at 10:37:35AM -0700, Matt Mills wrote:
> On Mon, Dec 12, 2011 at 3:41 AM, Martin Braun <address@hidden> wrote:
> 
>     * Do you randomly get either segfault or i/o error? I always get the i/o
>      with this code..
>
> I get both.
>  
> 
>     * Your code stresses the WAV-code a lot :) What are you trying to
>      accomplish? Are you finding a bug in wavfile_sink or do you need this
>      behaviour for something? Because you don't need close() if you just
>      want to switch files.
>     * In any case, you're right. It's possible to call close() during work()
>      after do_update() is finished and thus yank the fp out from under our
>      feet. Actually, I can't think of any case where we need to call
>      close() manually--perhaps it should even be private?
>  
> I don't think making close() private is really the right solution. I'm
> recording distinct conversations so having an open() unmute() mute() close()
> sequence per call makes the most sense (if a channel is idle for 20 minutes
> between transmissions then I'm going to have the last wav file open for 20
> minutes; unless I open a temporary file to write nothing to, which just seems
> silly).

Yes, that makes sense. Try this (is the same as what I sent to
patch-gnuradio). It works with your script.

MB


-- 
Karlsruhe Institute of Technology (KIT)
Communications Engineering Lab (CEL)

Dipl.-Ing. Martin Braun
Research Associate

Kaiserstraße 12
Building 05.01
76131 Karlsruhe

Phone: +49 721 608-43790
Fax: +49 721 608-46071
www.cel.kit.edu

KIT -- University of the State of Baden-Württemberg and
National Laboratory of the Helmholtz Association

0001-WAV-sink-is-now-threadsafe.patch
Description: Text Data

pgpSnLop9stJv.pgp
Description: PGP signature