Re: [dmidecode] [PATCH 1/1] dmioem: HPE OEM Record 199

[Jean Delvare]

On Thu, 4 Mar 2021 00:54:00 -0700, Jerry Hoemann wrote:
> Oh, I see.  Type 4 record is printing out the ID twice. Once as hex bytes,
> and the second time in more human friendly form.

Yes. Actually after reading the code again, I was thinking maybe we
could hide the raw form when the smart form is available, as least in
quiet mode. I'll see if that can be done easily.

> But, that is way too much code to duplicate. So, we probably
> want to pull that code into a standalone function that both
> the Type 4 record and the HPE OEM record 199 would call.
> 
> Do you want to do this?

To be honest I was thinking we would take shortcuts by assuming that
all HP/HPE ProLiant servers with this record are based on Intel i686 or
later CPU. I agree that having something more generic would be nice,
however it isn't trivial to reuse the code, because doing it right
requires to know the CPU brand and model, and that information is only
available after type 4 has been decoded. The type 4 record could in
theory be found *after* the type 199 record, so we may need to use a
two-pass approach again (same we did to save the OEM vendor string
early on).

Let's see what I can come up with.

-- 
Jean Delvare
SUSE L3 Support