Re: [dmidecode] [PATCH 3/6] dmidecode: Split CPUID type detection from dmi_processor_id

[Jerry Hoemann]

On Thu, Mar 04, 2021 at 05:47:21PM +0100, Jean Delvare wrote:
> Move the code which decides the CPUID type to a separate function, so
> that it can be called from a different context.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> ---
>  dmidecode.c |  210 
> ++++++++++++++++++++++++++++++++----------------------------
>  dmidecode.h |   12 +++
>  2 files changed, 127 insertions(+), 95 deletions(-)
> 




> --- dmidecode.orig/dmidecode.h        2021-03-04 15:41:02.176098460 +0100
> +++ dmidecode/dmidecode.h     2021-03-04 15:45:57.860593149 +0100
> @@ -31,6 +31,18 @@ struct dmi_header
>       u8 *data;
>  };
>  
> +enum cpuid_type
> +{
> +     cpuid_none,
> +     cpuid_80386,
> +     cpuid_80486,
> +     cpuid_arm,
> +     cpuid_x86_intel,
> +     cpuid_x86_amd,
> +};
> +
> +enum cpuid_type cpuid_type;

Multiple definitions.  Try:

extern enum cpuid_type cpuid_type;


> +
>  int is_printable(const u8 *data, int len);
>  const char *dmi_string(const struct dmi_header *dm, u8 s);
>  void dmi_print_memory_size(const char *addr, u64 code, int shift);
> 
> -- 
> Jean Delvare
> SUSE L3 Support

-- 

-----------------------------------------------------------------------------
Jerry Hoemann                  Software Engineer   Hewlett Packard Enterprise
-----------------------------------------------------------------------------