[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: change to query-replace-read-args

From: Eli Zaretskii
Subject: Re: change to query-replace-read-args
Date: Fri, 22 Mar 2002 12:24:11 +0200

> From: Colin Walters <address@hidden>
> Date: 22 Mar 2002 02:04:40 -0500
> What is the rationale behind the following change?

A user complained on gnu.emacs.bug that query-replace, when invoked on
a read-only buffer, only barfs after you are prompted for the FROM and
TO strings, which might take a lot of effort to construct.

>       * replace.el (query-replace-read-args): Immediate error if read-only.
> This breaks ibuffer's multi-buffer query replace functionality, as it
> uses `query-replace-read-args' to get the arguments, but the ibuffer
> buffer itself is read-only.

This could be solved by splitting `query-replace-read-args' into 2
parts, one that does the real work unconditionally, the other that
tests whether the buffer is read-only and only invokes the real code
if it isn't.  You could then use the unconditional part in ibuffer.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]