[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: address@hidden: Two problems in Emacs-21.2.91 on Windows]
From: |
Juanma Barranquero |
Subject: |
Re: address@hidden: Two problems in Emacs-21.2.91 on Windows] |
Date: |
Thu, 24 Oct 2002 10:40:04 +0200 |
On 24 Oct 2002 11:35:07 +0200, address@hidden (Kim F. Storm) wrote:
> dispextern.h seems like a good choice. It actually uses XColor in a
> prototype...
> I suggest adding the following near the top of the file:
>
> #ifdef HAVE_X_WINDOWS
> #include <X11/Xlib.h>
> #ifdef USE_X_TOOLKIT
> #include <X11/Intrinsic.h>
> #endif /* USE_X_TOOLKIT */
> + #else /* !HAVE_X_WINDOWS */
> +
> + /* X-related stuff used by non-X gui code. */
> +
> + typedef struct {
> + unsigned long pixel;
> + unsigned short red, green, blue;
> + char flags;
> + char pad;
> + } XColor;
> +
> #endif /* HAVE_X_WINDOWS */
OK.
> Avoiding [verbatim] duplication of code or defs always make me feel better :-)
Yeah :)
OK, so I'll wait for a while and if no one objects I'll rework
yesterday's patch to use your suggested fix.
Should it also be done on EMACS_21_1_RC?
/L/e/k/t/u
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], (continued)
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], Juanma Barranquero, 2002/10/23
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], Harald . Maier . BW, 2002/10/28
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], jasonr, 2002/10/23
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], Juanma Barranquero, 2002/10/23
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], Eli Zaretskii, 2002/10/23
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], Juanma Barranquero, 2002/10/24
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], Eli Zaretskii, 2002/10/24
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], Juanma Barranquero, 2002/10/24
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], Kim F. Storm, 2002/10/24
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows],
Juanma Barranquero <=
- Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], Eli Zaretskii, 2002/10/24
Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], jasonr, 2002/10/23
Re: address@hidden: Two problems in Emacs-21.2.91 on Windows], jasonr, 2002/10/24