emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Updated patch for a Windows implementation of play-sound - 2


From: Richard Stallman
Subject: Re: Updated patch for a Windows implementation of play-sound - 2
Date: Sun, 27 Oct 2002 18:37:50 -0500

    >  Oh and the "normal" #ifdef style used in Emacs is:
    >
    >   #if FOO
    >   #else /* !FOO */
    >   #endif /* !FOO */

Actually our normal style is to write /* not FOO */
rather than /* !FOO */

    I find this style of #ifdef blocks to be much too cryptic for my tastes.

It is a fine way of saying what command the #endif or #else matches.
However, that is all it does.  By all means write additional comments
to give more information!

      I find that it is much
    clearer if your comments for the #else and #endif portions state exactly
    what #ifdef line they go to 

What would it mean to "state exactly"?  How can you be more explicit
than our current convention?

    I would like to thank you for testing this patch on Linux.

Actually he tested it on the GNU/Linux system.  Linux alone is just
part of a system--you can't run anything on Linux but itself.
Would you please call the system "GNU/Linux"?

See http://www.gnu.org/gnu/linux-and-gnu.html and
http://www.gnu.org/gnu/gnu-linux-faq.html.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]