Re: font-lock in machine mode of gdba

[Stefan Monnier]

> +(defconst gdb-assembler-font-lock-keywords
> +  '(("\\$?0x*[0-9a-f]+" . font-lock-constant-face)
> +    ("<\\([^+>]+\\)\\+[0-9]+>:" 
> +     1 font-lock-function-name-face)
> +    ("%\\sw+" . font-lock-variable-name-face)
> +    ("^\\(Dump of assembler code for function\\) \\(.+\\):" 
> +     (1 font-lock-comment-face)
> +     (2 font-lock-function-name-face))
> +    ("^\\(End of assembler dump\\.\\)" . font-lock-comment-face))
> +    "Font lock keywords used in `gdb-assembler-mode'.")

Seems OK.
 
> +  (unless font-lock-mode (font-lock-mode 1))

This is WRONG.  The user should be able to choose whether he wants font-lock
or not.  He does that using either asm-mode-hook or global-font-lock-mode.


        Stefan