Re: Faces for Mode Line and Mode Line Inactive

[Stefan Monnier]

> Index: faces.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v
> retrieving revision 1.293
> diff -u -r1.293 faces.el
> --- faces.el  2 Dec 2004 10:56:05 -0000       1.293
> +++ faces.el  5 Dec 2004 22:21:30 -0000
> @@ -1786,16 +1786,16 @@
>    :group 'basic-faces)
 
>  (defface mode-line-inactive
> -  '((t
> -     :inherit mode-line)
> -    (((type x w32 mac) (background light) (class color))
> +  '((((type x w32 mac) (background light) (class color))
>       :weight light
>       :box (:line-width -1 :color "grey75" :style nil)
>       :foreground "grey20" :background "grey90")
>      (((type x w32 mac) (background dark) (class color))
>       :weight light
>       :box (:line-width -1 :color "grey40" :style nil)
> -     :foreground "grey80" :background "grey30"))
> +     :foreground "grey80" :background "grey30")
> +    (t
> +     :inherit mode-line))
>    "Basic mode line face for non-selected windows."
>    :version "21.4"
>    :group 'modeline

Please read the NEWS file.  You'll discover that the above patch changes
the behavior.  The current code unconditionally inherits from mode-line
whereas your change make it inherit only for things like ttys or
b&w displays.


        Stefan