Re: Faces for Mode Line and Mode Line Inactive

[Dan Nicolaescu]

Stefan Monnier <address@hidden> writes:

  > The code I see in faces.el is appended.  It says that the face
  > unconditionally inherits from mode-line.  This is how it should be, AFAIK.

[snip]
Not completely related to this discussion, but related to faces.el:
Shouldn't the mode-line and mode-line-inactive deffaces use
min-colors? (I somehow missed them when converting the other standard
deffaces to use min-colors).

May I check in this patch? 

*** faces.el    06 Dec 2004 07:51:19 -0800      1.293
--- faces.el    06 Dec 2004 10:37:26 -0800      
***************
*** 1775,1781 ****
  
  
  (defface mode-line
!   '((((type x w32 mac) (class color))
       :box (:line-width -1 :style released-button)
       :background "grey75" :foreground "black")
      (t
--- 1775,1781 ----
  
  
  (defface mode-line
!   '((((class color) (min-colors 88))
       :box (:line-width -1 :style released-button)
       :background "grey75" :foreground "black")
      (t
***************
*** 1788,1798 ****
  (defface mode-line-inactive
    '((t
       :inherit mode-line)
!     (((type x w32 mac) (background light) (class color))
       :weight light
       :box (:line-width -1 :color "grey75" :style nil)
       :foreground "grey20" :background "grey90")
!     (((type x w32 mac) (background dark) (class color))
       :weight light
       :box (:line-width -1 :color "grey40" :style nil)
       :foreground "grey80" :background "grey30"))
--- 1788,1798 ----
  (defface mode-line-inactive
    '((t
       :inherit mode-line)
!     (((background light) (class color) (min-colors 88))
       :weight light
       :box (:line-width -1 :color "grey75" :style nil)
       :foreground "grey20" :background "grey90")
!     (((background dark) (class color) (min-colors 88))
       :weight light
       :box (:line-width -1 :color "grey40" :style nil)
       :foreground "grey80" :background "grey30"))