Re: mouse-face on mode-line and header-line

[Luc Teirlinck]

For consistency should not also the following changes be made?  I can
install them, if desired.  They are the result of grepping for
make-mode-line-mouse-map in the Lisp directory.

I guess that changes to gnus should also work for older Emacs versions
and for XEmacs.  But before your changes were mouse-face properties
not simply ignored in the mode line?  In that case, there should not
be any incompatibility problems.

===File ~/gnus-agent-diff===================================
*** gnus-agent.el       10 Apr 2005 07:29:46 -0500      1.15
--- gnus-agent.el       23 May 2005 15:43:09 -0500      
***************
*** 561,567 ****
    (if (and (fboundp 'propertize)
           (fboundp 'make-mode-line-mouse-map))
        (propertize string 'local-map
!                 (make-mode-line-mouse-map mouse-button mouse-func))
      string))
  
  (defun gnus-agent-toggle-plugged (set-to)
--- 561,568 ----
    (if (and (fboundp 'propertize)
           (fboundp 'make-mode-line-mouse-map))
        (propertize string 'local-map
!                 (make-mode-line-mouse-map mouse-button mouse-func)
!                 'mouse-face 'mode-line-highlight)
      string))
  
  (defun gnus-agent-toggle-plugged (set-to)
============================================================

===File ~/calendar-diff=====================================
*** calendar.el 16 May 2005 08:33:15 -0500      1.169
--- calendar.el 23 May 2005 15:46:59 -0500      
***************
*** 2335,2340 ****
--- 2335,2341 ----
     (propertize (substitute-command-keys
                "\\<calendar-mode-map>\\[scroll-calendar-left]")
               'help-echo "mouse-2: scroll left"
+              'mouse-face 'mode-line-highlight
               'keymap (make-mode-line-mouse-map 'mouse-2
                                                 'mouse-scroll-calendar-left))
     "Calendar"
***************
*** 2343,2354 ****
--- 2344,2357 ----
       (substitute-command-keys
        "\\<calendar-mode-map>\\[calendar-goto-info-node] info")
       'help-echo "mouse-2: read Info on Calendar"
+      'mouse-face 'mode-line-highlight
       'keymap (make-mode-line-mouse-map 'mouse-2 'calendar-goto-info-node))
      "/"
      (propertize
       (substitute-command-keys
       "\\<calendar-mode-map>\\[calendar-other-month] other")
       'help-echo "mouse-2: choose another month"
+      'mouse-face 'mode-line-highlight
       'keymap (make-mode-line-mouse-map
              'mouse-2 'mouse-calendar-other-month))
      "/"
***************
*** 2356,2366 ****
--- 2359,2371 ----
       (substitute-command-keys
       "\\<calendar-mode-map>\\[calendar-goto-today] today")
       'help-echo "mouse-2: go to today's date"
+      'mouse-face 'mode-line-highlight
       'keymap (make-mode-line-mouse-map 'mouse-2 #'calendar-goto-today)))
     '(calendar-date-string (calendar-current-date) t)
     (propertize (substitute-command-keys
                "\\<calendar-mode-map>\\[scroll-calendar-right]")
               'help-echo "mouse-2: scroll right"
+              'mouse-face 'mode-line-highlight
               'keymap (make-mode-line-mouse-map
                        'mouse-2 'mouse-scroll-calendar-right)))
    "The mode line of the calendar buffer.
============================================================

===File ~/time-diff=========================================
*** time.el     16 May 2005 08:32:48 -0500      1.83
--- time.el     23 May 2005 15:34:55 -0500      
***************
*** 200,205 ****
--- 200,206 ----
                                  (list :background bg)))))
          'face display-time-mail-face
          'help-echo "You have new mail; mouse-2: Read mail"
+         'mouse-face 'mode-line-highlight
          'local-map (make-mode-line-mouse-map 'mouse-2
                                               read-mail-command)))
        ""))
***************
*** 293,298 ****
--- 294,300 ----
                          (concat (substring str 0 -2) "." (substring str -2))
                          'local-map (make-mode-line-mouse-map
                                      'mouse-2 'display-time-next-load-average)
+                         'mouse-face 'mode-line-highlight
                          'help-echo (concat
                                      "System load average for past "
                                      (if (= 0 display-time-load-average)
============================================================