Re: doc-view support for bookmark.el

[Stefan Monnier]

>>> on emacs-sources there was a request for a bookmarking facility for
>>> doc-view, so I added support for it in bookmark.el.
>> 
>> Could we try and find a way to make the two packages independent:
>> bookmark.el should provide a way for doc-view.el to override the
>> behavior of bookmark commands in doc-view buffers.

> Sure, a general interface would be a good idea.  Do you propose an one?

> A simple approach could be to add 2 new variables

>   - bookmark-make-cell-function: A function that creates the record part
>     of the bookmark (default: the current bookmark-make-cell after
>     renaming it appropriately)

>   - bookmark-jump-function: A function that jumps to the given bookmark
>     location without selecting it. (default: the current
>     bookmark-jump-noselect)

> What do you think?

I don't have time to look into it right now, but I'd have expected that
the second one is not needed: doc-view's bookmark-make-cell-function
would create a bookmark entry which contains a callback to doc-view, so
that bookmark-jump would not need a bookmark-jump-function, or in other
words the bookmark-jump-function shouldn't be a global (buffer-local)
variable, but an (optional) entry in each bookmark.


        Stefan