emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: doc-view support for bookmark.el


From: Stefan Monnier
Subject: Re: doc-view support for bookmark.el
Date: Tue, 25 Dec 2007 18:07:32 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux)

> +       (if handler
> +                (funcall handler bookmark)
> +              (bookmark-jump-noselect bookmark))))

Aka (funcall (or handler 'bookmark-jump-noselect) bookmark)

> Do you think it's ok and I should install it?

Looks good from a cursory glance at it, although the repetition of all those
bookmark-get-handler + if + funcall is begging for some redundancy-reduction.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]